Skip to content

add name and message to frontendend exception handler#5585

Merged
adhami3310 merged 4 commits into
mainfrom
add-name-and-message-to-frontendend-exception-handler
Jul 17, 2025
Merged

add name and message to frontendend exception handler#5585
adhami3310 merged 4 commits into
mainfrom
add-name-and-message-to-frontendend-exception-handler

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR improves frontend error handling by adding more detailed error information throughout the error handling chain. The changes ensure that error name and message are included alongside stack traces, providing better context for debugging. Key changes include:

  • Modified handle_frontend_exception in state.py to accept fuller error information
  • Enhanced JavaScript error handlers in state.js to send error name and message
  • Updated error boundary component to display and handle the expanded error format

These changes create a more consistent and informative error reporting system across the frontend-backend boundary, making it easier for developers to diagnose and fix issues.

Confidence score: 5/5

  1. This PR is very safe to merge as it purely enhances error reporting without modifying core functionality
  2. The changes are well-coordinated across all relevant files and follow a consistent pattern of improvement
  3. While all files look good, developers might want to double-check the error formatting in error_boundary.py to ensure the display format meets their expectations

3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 16, 2025

CodSpeed Performance Report

Merging #5585 will not alter performance

Comparing add-name-and-message-to-frontendend-exception-handler (a6e6eb6) with main (d324b25)

Summary

✅ 8 untouched benchmarks

Copy link
Copy Markdown
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, approve when unit tests are fixed up

@adhami3310 adhami3310 merged commit 9268189 into main Jul 17, 2025
41 checks passed
@adhami3310 adhami3310 deleted the add-name-and-message-to-frontendend-exception-handler branch July 17, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants